Feature/support keypair generation by HunsupJung · Pull Request #2815 · SmartThingsCommunity/SmartThingsEdgeDrivers

HunsupJung · 2026-02-27T11:05:47Z

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

github-actions · 2026-02-27T11:07:04Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/adMKXL5K4J29

github-actions · 2026-02-27T11:08:02Z

Test Results

72 files 493 suites 0s ⏱️
2 699 tests 2 699 ✅ 0 💤 0 ❌
4 560 runs 4 560 ✅ 0 💤 0 ❌

Results for commit 7aeef13.

♻️ This comment has been updated with latest results.

HunsupJung · 2026-02-27T11:08:02Z

@tpmanley
I entered the Git command incorrectly and the PR was closed, but I couldn't open it again to see if I didn't have the authority, so I made a new one. I'm sorry to bother you.

github-actions · 2026-02-27T11:08:03Z

File	Coverage
All files	`80%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua	`69%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua	`92%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/can_handle.lua	`90%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua	`77%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 7aeef13

HunsupJung · 2026-02-27T12:35:47Z

@tpmanley

Thanks for the making the requested changes @HunsupJung . The driver code is looking pretty good to me now. In addition to what @ctowns suggested, can you also take a look at the unit tests failures reported by CI and try to add tests for the new code?

First of all, I corrected all the errors.

HunsupJung · 2026-02-27T12:47:23Z

@ctowns
if test code uses lock-modular, the following message appears as if lockAliro capability is not supported, making it impossible to write test code. What do you suggest I do?

INFO  || <MatterDevice: 00000000-1111-2222-3333-000000000001 [nil]> received InteractionResponse: <InteractionResponse || type: REPORT_DATA, response_blocks: [<InteractionResponseInfoBlock || status: SUCCESS, <InteractionInfoBlock || endpoint: 0x01, cluster: DoorLock, attribute: AliroReaderVerificationKey, data: OctetString1: "\x04\xA9\xCB\xE4\x18\xEB\x09\x66\x16\x43\xE2\xA4\xA8\x46\xB8\xED\xFE\x27\x86\x98\x30\x2E\x9F\xB4\x3E\x9B\xFF\xD3\xE3\x10\xCC\x2C\x2C\x7F\xF4\x02\xE0\x6E\x40\xEA\x3C\xE1\x29\x43\x52\x73\x36\x68\x3F\xC5\xB1\xCB\x0C\x6A\x7C\x3F\x0B\x5A\xFF\x78\x35\xDF\x21\xC6\x24">>]>
TRACE || Found MatterMessageDispatcher handler in matter-lock -> New Matter Lock Handler
WARN  || Attempted to generate event for 00000000-1111-2222-3333-000000000001.main but it does not support capability Lock Aliro

hcarter-775 · 2026-02-27T16:56:04Z

@HunsupJung when you're setting up the test, you can make a mock device with the following profile
profile = t_utils.get_profile_definition("lock-modular.yml", {enabled_optional_capabilities = {{"main", {"lockAliro"}}}}),

Then run the test as normal. This will make the tested profile include the optional capability. You can add as many optional capabilities as you want in this way.

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua

drivers/SmartThings/matter-lock/src/test/test_new_matter_lock_battery.lua

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua

HunsupJung · 2026-03-12T12:13:43Z

@tpmanley
I completed update. Could you review it again?

tpmanley · 2026-03-12T21:42:11Z

Thanks for resolving my two comments. There are a couple of conflicts right now so what I'd recommend is squash and rebase your changes into a single commit on top of latest main branch and then we can give it hopefully the last final review.

HunsupJung · 2026-03-13T11:22:26Z

@tpmanley
I did squash and rebase the commits.

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua

hcarter-775 · 2026-03-17T17:15:49Z

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua

  BATTERY_SUPPORT = "__BATTERY_SUPPORT",
 }

+local DoorLockFeatureMapAttr = {ID = 0xFFFC, cluster = DoorLock.ID}


@gharveymn it doesn't seem like we have any way to represent this naturally in the generated clusters. Do you have any context for why? And do you have any recomendations on how to integrate it in the driver "naturally"?

I'm thinking we may want to handle it as:

Suggested change

local DoorLockFeatureMapAttr = {ID = 0xFFFC, cluster = DoorLock.ID}

local DoorLock.attributes.FeatureMap = {

ID = 0xFFFC,

NAME = "FeatureMap",

_cluster = require "st.matter.clusters.DoorLock",

base_type = require "st.matter.clusters.DoorLock.types.Feature",

}

I'm mainly thinking of 1. whether/how we'd subscribe to this, and 2. whether we can make unit tests for it.

Not really too much context. I wasn't involved in the PRs which did the filtering. We also filter two other attributes: GeneratedCommandList and ClusterRevision, but those make sense since we don't act as a server in Lua-land.

I don't really see a reason not to add cluster-specific attribute definitions in scripting-engine for each of these where the base type is types.Feature. You may run into an issue where the Feature type doesn't exist for certain clusters, but you can just work around that by making the base type U32 or something.

The way you proposed would be a start, but I think you would be missing certain functions which would be a blocker for (1) and (2). Perhaps you can make some adjustments to the ZAP generation for scripting-engine locally, and then export the attribute definition as an embedded cluster attribute for now.

@HunsupJung to integrate this more cleanly, I think we should add the following file DoorLock/server/attributes/FeatureMap.lua for the embedded cluster definition:

local cluster_base = require "st.matter.cluster_base" local data_types = require "st.matter.data_types" local TLVParser = require "st.matter.TLV.TLVParser" local FeatureMap = { ID = 0xFFFC, NAME = "FeatureMap", _cluster = require "st.matter.clusters.DoorLock", base_type = require "st.matter.clusters.DoorLock.types.Feature", } function FeatureMap:augment_type(data_type_obj) for i, v in ipairs(data_type_obj.elements) do data_type_obj.elements[i] = data_types.validate_or_build_type(v, FeatureMap.element_type) end end function FeatureMap:new_value(...) local o = self.base_type(table.unpack({...})) return o end function FeatureMap:read(device, endpoint_id) return cluster_base.read( device, endpoint_id, self._cluster.ID, self.ID, nil ) end function FeatureMap:subscribe(device, endpoint_id) return cluster_base.subscribe( device, endpoint_id, self._cluster.ID, self.ID, nil ) end function FeatureMap:set_parent_cluster(cluster) self._cluster = cluster return self end function FeatureMap:build_test_report_data( device, endpoint_id, value, status ) local data = data_types.validate_or_build_type(value, self.base_type) return cluster_base.build_test_report_data( device, endpoint_id, self._cluster.ID, self.ID, data, status ) end function FeatureMap:deserialize(tlv_buf) local data = TLVParser.decode_tlv(tlv_buf) return data end setmetatable(FeatureMap, {__call = FeatureMap.new_value, __index = FeatureMap.base_type}) return FeatureMap

Then we can maybe, at the top of the file, update the version check to something like:

if version.api < 10 then clusters.DoorLock = require "DoorLock" else clusters.DoorLock.attributes.FeatureMap = require "DoorLock.server.attributes.FeatureMap" end

Besides making this "cleaner", I think we should create unit tests for this newly introduced logic, and we will need this to create proper unit tests.

The code below is not working. Because cluster.DoorLock.attributes.FeatureMap is not declared, override is not possible.

clusters.DoorLock.attributes.FeatureMap = require "DoorLock.server.attributes.FeatureMap"

It would be better to modify this part in the subsequent scripting-engine update.
https://samsung.slack.com/archives/C063J01GHR6/p1765382793593279?thread_ts=1732583132.684279&cid=C063J01GHR6

I agree that we should modify the scripting-engine. However, I think we should be able to include unit tests for this new profile changing feature to ensure that everything works properly.

That said, I looked into your issues and made the following changes:

local cluster_base = require "st.matter.cluster_base" local data_types = require "st.matter.data_types" local TLVParser = require "st.matter.TLV.TLVParser" local FeatureMap = { ID = 0xFFFC, NAME = "FeatureMap", _cluster = require "DoorLock", base_type = require "DoorLock.types.Feature", } function FeatureMap:augment_type(data_type_obj) for i, v in ipairs(data_type_obj.elements) do data_type_obj.elements[i] = data_types.validate_or_build_type(v, FeatureMap.element_type) end end function FeatureMap:new_value(...) local o = self.base_type(table.unpack({...})) return o end function FeatureMap:read(device, endpoint_id) return cluster_base.read( device, endpoint_id, self._cluster.ID, self.ID, nil ) end function FeatureMap:subscribe(device, endpoint_id) return cluster_base.subscribe( device, endpoint_id, self._cluster.ID, self.ID, nil ) end function FeatureMap:set_parent_cluster(cluster) self._cluster = cluster return self end function FeatureMap:build_test_report_data( device, endpoint_id, value, status ) local data = data_types.validate_or_build_type(value, self.base_type) return cluster_base.build_test_report_data( device, endpoint_id, self._cluster.ID, self.ID, data, status ) end function FeatureMap:deserialize(tlv_buf) local data = TLVParser.decode_tlv(tlv_buf) return data end setmetatable(FeatureMap, {__call = FeatureMap.new_value, __index = FeatureMap.base_type}) return FeatureMap

should be the file, and

-- Copyright 2025 SmartThings, Inc. -- Licensed under the Apache License, Version 2.0 local cluster_base = require "st.matter.cluster_base" local DoorLockServerAttributes = require "DoorLock.server.attributes" local DoorLockServerCommands = require "DoorLock.server.commands" local DoorLockClientCommands = require "DoorLock.client.commands" local DoorLockEvents = require "DoorLock.server.events" local DoorLockTypes = require "DoorLock.types" local DoorLock = {} DoorLock.ID = 0x0101 DoorLock.NAME = "DoorLock" DoorLock.server = {} DoorLock.client = {} DoorLock.server.attributes = DoorLockServerAttributes:set_parent_cluster(DoorLock) DoorLock.server.commands = DoorLockServerCommands:set_parent_cluster(DoorLock) DoorLock.client.commands = DoorLockClientCommands:set_parent_cluster(DoorLock) DoorLock.server.events = DoorLockEvents:set_parent_cluster(DoorLock) DoorLock.types = DoorLockTypes function DoorLock:get_attribute_by_id(attr_id) local attr_id_map = { [0x0000] = "LockState", [0x0001] = "LockType", [0x0002] = "ActuatorEnabled", [0x0003] = "DoorState", [0x0004] = "DoorOpenEvents", [0x0005] = "DoorClosedEvents", [0x0006] = "OpenPeriod", [0x0011] = "NumberOfTotalUsersSupported", [0x0012] = "NumberOfPINUsersSupported", [0x0013] = "NumberOfRFIDUsersSupported", [0x0014] = "NumberOfWeekDaySchedulesSupportedPerUser", [0x0015] = "NumberOfYearDaySchedulesSupportedPerUser", [0x0016] = "NumberOfHolidaySchedulesSupported", [0x0017] = "MaxPINCodeLength", [0x0018] = "MinPINCodeLength", [0x0019] = "MaxRFIDCodeLength", [0x001A] = "MinRFIDCodeLength", [0x001B] = "CredentialRulesSupport", [0x001C] = "NumberOfCredentialsSupportedPerUser", [0x0021] = "Language", [0x0022] = "LEDSettings", [0x0023] = "AutoRelockTime", [0x0024] = "SoundVolume", [0x0025] = "OperatingMode", [0x0026] = "SupportedOperatingModes", [0x0027] = "DefaultConfigurationRegister", [0x0028] = "EnableLocalProgramming", [0x0029] = "EnableOneTouchLocking", [0x002A] = "EnableInsideStatusLED", [0x002B] = "EnablePrivacyModeButton", [0x002C] = "LocalProgrammingFeatures", [0x0030] = "WrongCodeEntryLimit", [0x0031] = "UserCodeTemporaryDisableTime", [0x0032] = "SendPINOverTheAir", [0x0033] = "RequirePINforRemoteOperation", [0x0035] = "ExpiringUserTimeout", [0x0080] = "AliroReaderVerificationKey", [0x0081] = "AliroReaderGroupIdentifier", [0x0082] = "AliroReaderGroupSubIdentifier", [0x0083] = "AliroExpeditedTransactionSupportedProtocolVersions", [0x0084] = "AliroGroupResolvingKey", [0x0085] = "AliroSupportedBLEUWBProtocolVersions", [0x0086] = "AliroBLEAdvertisingVersion", [0x0087] = "NumberOfAliroCredentialIssuerKeysSupported", [0x0088] = "NumberOfAliroEndpointKeysSupported", [0xFFF9] = "AcceptedCommandList", [0xFFFA] = "EventList", [0xFFFB] = "AttributeList", [0xFFFC] = "FeatureMap", } local attr_name = attr_id_map[attr_id] if attr_name ~= nil then return self.attributes[attr_name] end return nil end function DoorLock:get_server_command_by_id(command_id) local server_id_map = { [0x0000] = "LockDoor", [0x0001] = "UnlockDoor", [0x0003] = "UnlockWithTimeout", [0x000B] = "SetWeekDaySchedule", [0x000C] = "GetWeekDaySchedule", [0x000D] = "ClearWeekDaySchedule", [0x000E] = "SetYearDaySchedule", [0x000F] = "GetYearDaySchedule", [0x0010] = "ClearYearDaySchedule", [0x0011] = "SetHolidaySchedule", [0x0012] = "GetHolidaySchedule", [0x0013] = "ClearHolidaySchedule", [0x001A] = "SetUser", [0x001B] = "GetUser", [0x001D] = "ClearUser", [0x0022] = "SetCredential", [0x0024] = "GetCredentialStatus", [0x0026] = "ClearCredential", [0x0027] = "UnboltDoor", [0x0028] = "SetAliroReaderConfig", [0x0029] = "ClearAliroReaderConfig", } if server_id_map[command_id] ~= nil then return self.server.commands[server_id_map[command_id]] end return nil end function DoorLock:get_client_command_by_id(command_id) local client_id_map = { [0x000C] = "GetWeekDayScheduleResponse", [0x000F] = "GetYearDayScheduleResponse", [0x0012] = "GetHolidayScheduleResponse", [0x001C] = "GetUserResponse", [0x0023] = "SetCredentialResponse", [0x0025] = "GetCredentialStatusResponse", } if client_id_map[command_id] ~= nil then return self.client.commands[client_id_map[command_id]] end return nil end function DoorLock:get_event_by_id(event_id) local event_id_map = { [0x0000] = "DoorLockAlarm", [0x0001] = "DoorStateChange", [0x0002] = "LockOperation", [0x0003] = "LockOperationError", [0x0004] = "LockUserChange", } if event_id_map[event_id] ~= nil then return self.server.events[event_id_map[event_id]] end return nil end DoorLock.attribute_direction_map = { ["LockState"] = "server", ["LockType"] = "server", ["ActuatorEnabled"] = "server", ["DoorState"] = "server", ["DoorOpenEvents"] = "server", ["DoorClosedEvents"] = "server", ["OpenPeriod"] = "server", ["NumberOfTotalUsersSupported"] = "server", ["NumberOfPINUsersSupported"] = "server", ["NumberOfRFIDUsersSupported"] = "server", ["NumberOfWeekDaySchedulesSupportedPerUser"] = "server", ["NumberOfYearDaySchedulesSupportedPerUser"] = "server", ["NumberOfHolidaySchedulesSupported"] = "server", ["MaxPINCodeLength"] = "server", ["MinPINCodeLength"] = "server", ["MaxRFIDCodeLength"] = "server", ["MinRFIDCodeLength"] = "server", ["CredentialRulesSupport"] = "server", ["NumberOfCredentialsSupportedPerUser"] = "server", ["Language"] = "server", ["LEDSettings"] = "server", ["AutoRelockTime"] = "server", ["SoundVolume"] = "server", ["OperatingMode"] = "server", ["SupportedOperatingModes"] = "server", ["DefaultConfigurationRegister"] = "server", ["EnableLocalProgramming"] = "server", ["EnableOneTouchLocking"] = "server", ["EnableInsideStatusLED"] = "server", ["EnablePrivacyModeButton"] = "server", ["LocalProgrammingFeatures"] = "server", ["WrongCodeEntryLimit"] = "server", ["UserCodeTemporaryDisableTime"] = "server", ["SendPINOverTheAir"] = "server", ["RequirePINforRemoteOperation"] = "server", ["ExpiringUserTimeout"] = "server", ["AliroReaderVerificationKey"] = "server", ["AliroReaderGroupIdentifier"] = "server", ["AliroReaderGroupSubIdentifier"] = "server", ["AliroExpeditedTransactionSupportedProtocolVersions"] = "server", ["AliroGroupResolvingKey"] = "server", ["AliroSupportedBLEUWBProtocolVersions"] = "server", ["AliroBLEAdvertisingVersion"] = "server", ["NumberOfAliroCredentialIssuerKeysSupported"] = "server", ["NumberOfAliroEndpointKeysSupported"] = "server", ["AcceptedCommandList"] = "server", ["EventList"] = "server", ["AttributeList"] = "server", ["FeatureMap"] = "server", } DoorLock.command_direction_map = { ["LockDoor"] = "server", ["UnlockDoor"] = "server", ["UnlockWithTimeout"] = "server", ["SetWeekDaySchedule"] = "server", ["GetWeekDaySchedule"] = "server", ["ClearWeekDaySchedule"] = "server", ["SetYearDaySchedule"] = "server", ["GetYearDaySchedule"] = "server", ["ClearYearDaySchedule"] = "server", ["SetHolidaySchedule"] = "server", ["GetHolidaySchedule"] = "server", ["ClearHolidaySchedule"] = "server", ["SetUser"] = "server", ["GetUser"] = "server", ["ClearUser"] = "server", ["SetCredential"] = "server", ["GetCredentialStatus"] = "server", ["ClearCredential"] = "server", ["UnboltDoor"] = "server", ["SetAliroReaderConfig"] = "server", ["ClearAliroReaderConfig"] = "server", ["GetWeekDayScheduleResponse"] = "client", ["GetYearDayScheduleResponse"] = "client", ["GetHolidayScheduleResponse"] = "client", ["GetUserResponse"] = "client", ["SetCredentialResponse"] = "client", ["GetCredentialStatusResponse"] = "client", } DoorLock.FeatureMap = DoorLock.types.Feature function DoorLock.are_features_supported(feature, feature_map) if (DoorLock.FeatureMap.bits_are_valid(feature)) then return (feature & feature_map) == feature end return false end local attribute_helper_mt = {} attribute_helper_mt.__index = function(self, key) local direction = DoorLock.attribute_direction_map[key] if direction == nil then error(string.format("Referenced unknown attribute %s on cluster %s", key, DoorLock.NAME)) end return DoorLock[direction].attributes[key] end DoorLock.attributes = {} setmetatable(DoorLock.attributes, attribute_helper_mt) local command_helper_mt = {} command_helper_mt.__index = function(self, key) local direction = DoorLock.command_direction_map[key] if direction == nil then error(string.format("Referenced unknown command %s on cluster %s", key, DoorLock.NAME)) end return DoorLock[direction].commands[key] end DoorLock.commands = {} setmetatable(DoorLock.commands, command_helper_mt) local event_helper_mt = {} event_helper_mt.__index = function(self, key) return DoorLock.server.events[key] end DoorLock.events = {} setmetatable(DoorLock.events, event_helper_mt) setmetatable(DoorLock, {__index = cluster_base}) return DoorLock

should be the init.lua file. Then this will work:

if version.api < 10 then clusters.DoorLock = require "DoorLock" else clusters.DoorLock.attributes.FeatureMap = require "DoorLock.server.attributes.FeatureMap" end

I think we should do the above and then add the following tests.

Ensure the the profiles updates when the feature map changes.

Ensure the profile update does not occur when the feature map doesn't change but we get a handler event

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua

hcarter-775 · 2026-03-18T15:32:48Z

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua

+  if version.api >= 15 and version.rpc >= 9 then
+    match_profile_modular(driver, device)
+  end


This will not work currently, since it will no longer check for profiling data (that function is done at the start of match_profile). We should either add a parameter to match_profile called modular_only or something, or just move that profiling data function into the sub match profile functions.

It does not need to read PowerSource cluster again since it is only related to the DoorLock cluster. (I mean that match_profile can be used here.)

If it needs to check DPS feature, I will add it in DPS PR.

I still think we need this profiling_data check as a safety precaution.

Since we will subscribe to this attribute and the power source attribute list attribute when a device is first onboarded, it is possible that this handler will run before the power source attribute list handler. We cannot guarantee that ordering. This may cause 2 profile updates in a short period, which causes significant latency, so we should avoid this.

It makes sense. I will consider this part and modify.

I do not think we need to check if the profile is a modular profile, I think we need to add a way to handle the profiling_data_still_required check.

Basically, I suggest that we edit the match_profile function:

local function match_profile(driver, device, ignore_static_profiling) if profiling_data_still_required(device) then return end if version.api >= 15 and version.rpc >= 9 then match_profile_modular(driver, device) elseif ignore_static_profiling ~= true then match_profile_switch(driver, device) end end

and change this to:

match_profile(driver, device, true)

I think we can remove the new IS_MODULAR_PROFILE field.

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung · 2026-03-20T14:19:36Z

@hcarter-775
After squeezing the commits, I lost all the commits after the previous squeze.
I created all the modification again, but please check if there is anything missing.

HunsupJung requested review from Kwang-Hui, ctowns, hcarter-775, nickolas-deboom and tpmanley February 27, 2026 11:05

nickolas-deboom reviewed Feb 27, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

nickolas-deboom reviewed Feb 27, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Show resolved Hide resolved

nickolas-deboom reviewed Feb 27, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/test/test_new_matter_lock_battery.lua Outdated Show resolved Hide resolved

nickolas-deboom reviewed Feb 27, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/test/test_new_matter_lock_battery.lua Outdated Show resolved Hide resolved

nickolas-deboom reviewed Feb 27, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/test/test_new_matter_lock_battery.lua Outdated Show resolved Hide resolved

HunsupJung force-pushed the feature/support-keypair-generation branch from a90c386 to b331d2d Compare March 3, 2026 13:29

HunsupJung requested a review from nickolas-deboom March 3, 2026 13:31

tpmanley reviewed Mar 9, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

tpmanley reviewed Mar 9, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

HunsupJung requested a review from tpmanley March 12, 2026 01:40

HunsupJung force-pushed the feature/support-keypair-generation branch from 199cfbd to 98a69db Compare March 13, 2026 11:15

hcarter-775 reviewed Mar 13, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

HunsupJung requested a review from hcarter-775 March 16, 2026 23:46

hcarter-775 reviewed Mar 17, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

HunsupJung force-pushed the feature/support-keypair-generation branch from f6dac7a to b983f96 Compare March 18, 2026 12:17

HunsupJung requested a review from hcarter-775 March 18, 2026 12:19

hcarter-775 reviewed Mar 18, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

hcarter-775 reviewed Mar 18, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

hcarter-775 reviewed Mar 18, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

HunsupJung force-pushed the feature/support-keypair-generation branch from 6b496a8 to 8da3bdc Compare March 19, 2026 08:10

HunsupJung requested review from gharveymn and hcarter-775 March 19, 2026 12:04

hcarter-775 reviewed Mar 19, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Show resolved Hide resolved

hcarter-775 reviewed Mar 19, 2026

View reviewed changes

drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua Outdated Show resolved Hide resolved

HunsupJung force-pushed the feature/support-keypair-generation branch 3 times, most recently from 5ab11d7 to 98a69db Compare March 20, 2026 12:22

Support keypair generation

c36f336

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung force-pushed the feature/support-keypair-generation branch 5 times, most recently from 8f3a239 to e6c9a26 Compare March 20, 2026 13:29

HunsupJung requested a review from hcarter-775 March 20, 2026 13:30

HunsupJung force-pushed the feature/support-keypair-generation branch from e6c9a26 to 56007f0 Compare March 20, 2026 13:35

Move util code to lock_utils

7aeef13

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung force-pushed the feature/support-keypair-generation branch from 56007f0 to 7aeef13 Compare March 20, 2026 14:08

-local DoorLockFeatureMapAttr = {ID = 0xFFFC, cluster = DoorLock.ID}
+local DoorLock.attributes.FeatureMap = {
+  ID = 0xFFFC,
+  NAME = "FeatureMap",
+  _cluster = require "st.matter.clusters.DoorLock",
+  base_type = require "st.matter.clusters.DoorLock.types.Feature",
+}

Conversation

HunsupJung commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

HunsupJung commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HunsupJung commented Feb 27, 2026

Uh oh!

HunsupJung commented Feb 27, 2026

Uh oh!

hcarter-775 commented Feb 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HunsupJung commented Mar 12, 2026

Uh oh!

tpmanley commented Mar 12, 2026

Uh oh!

HunsupJung commented Mar 13, 2026

Uh oh!

Uh oh!

hcarter-775 Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hcarter-775 Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hcarter-775 Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HunsupJung commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

HunsupJung commented Feb 27, 2026 •

edited

Loading

github-actions bot commented Feb 27, 2026 •

edited

Loading

github-actions bot commented Feb 27, 2026 •

edited

Loading

hcarter-775 Mar 17, 2026 •

edited

Loading

hcarter-775 Mar 19, 2026 •

edited

Loading

hcarter-775 Mar 19, 2026 •

edited

Loading